Repository navigation
CI: show live Drive test progress and run after offline failures - #403
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the live Drive workflow changes.
No open issues 🎉
What changed in this PR
This PR improves visibility and resilience of the live Drive test workflow, addressing the unclear pending status and skipped live tests observed in #395.
Changes:
- Adds descriptive pending, success, and failure messages to the required
Live Drive testsstatus. - Allows eligible live tests to run after offline failures when dependency installation succeeds and the workflow is not cancelled.
- Preserves offline failures as job failures and keeps existing fork and Dependabot approval restrictions.
| File | Description |
|---|---|
.github/workflows/test.yml |
Tracks dependency installation and adjusts the live-test condition to allow execution after offline failures. |
.github/workflows/drive-status.yml |
Adds state-specific status descriptions while retaining the workflow progress link. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live Drive tests already start automatically on internal PRs. On #395,
GitHub showed “Waiting for status to be reported” while the matrix was running
because the pending commit status had an empty description. The Windows 3.15
packaging failure also skipped the live suite for that runner. Original run
The required
Live Drive testsstatus now says when the workflow has startedand links to its progress. A successful dependency install lets the live suite
run even if offline tests fail. An offline failure still fails the job and
blocks merging. Fork and Dependabot PRs still use the maintainer approval flow.
Validation
failures, cancellation, pushes, and manual dispatch.
checked the status name, description, commit, and run URL.